Messages in this thread | | | Date | Fri, 29 Aug 2008 12:42:14 +0200 | From | Tejun Heo <> | Subject | Re: Regression: SATA disk double spin-off during hibernation on hp nx6325 |
| |
Rafael J. Wysocki wrote: > Actaully, they do belong to it. This is the part "fixing" the hibernation code > path, in which the disk is also powered off unnecessarily. > > Well, probably I should use SYSTEM_HIBERNATE_ENTER or something similar > instead of SYSTEM_SUSPEND_DISK. > > In short, the idea is to change system_state to something specific to the last > phase of hibernation (after saving the image) and check that in > ata_scsi_start_stop_xlat(). In fact that's completely analogous to what's done > for SYSTEM_POWER_OFF in there.
Ah.. right, missed the added check for SUSPEND_DISK in libata-scsi.c. Maybe it's a good idea to note it in the commit message later?
Thanks.
-- tejun
| |