lkml.org 
[lkml]   [2008]   [Aug]   [28]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 28 Aug 2008 10:11:13 +0200
FromJens Axboe <>
SubjectRe: 2.6.27-rc4: lots of 'in_atomic():1, irqs_disabled():0' with software-raid1
On Thu, Aug 28 2008, Andre Noll wrote:
> On 09:48, Jens Axboe wrote:> > Doh right, we of course can't block inside a RCU section. Then
> > bitmap.c:write_sb_page() wants fixing:> > > >         rcu_read_lock();
> >         rdev_for_each_rcu(...)
> >                 md_super_write(...)
> >                         bio_alloc(GFP_NOIO, 1);> > Also, md_super_write() does not check the return value of bio_alloc().
> That probably needs fixing as well.

No, that's the guarentee of mempool_alloc() - as long as you have
__GFP_WAIT set, you'll never see a NULL return.

-- 
Jens Axboe



\
 
 \ /
  Last update: 2008-08-28 10:15    [from the cache]
©2003-2008