lkml.org 
[lkml]   [2008]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] block: kmalloc args reversed, small function definition fixes
    On Thu, Aug 28, 2008 at 09:26:21AM +0200, Jens Axboe wrote:
    > On Wed, Aug 27 2008, Harvey Harrison wrote:
    > > Noticed by sparse:
    > > block/blk-softirq.c:156:12: warning: symbol 'blk_softirq_init' was not declared. Should it be static?
    > > block/genhd.c:583:28: warning: function 'bdget_disk' with external linkage has definition
    > > block/genhd.c:659:17: warning: incorrect type in argument 1 (different base types)
    > > block/genhd.c:659:17: expected unsigned int [unsigned] [usertype] size
    > > block/genhd.c:659:17: got restricted gfp_t
    > > block/genhd.c:659:29: warning: incorrect type in argument 2 (different base types)
    > > block/genhd.c:659:29: expected restricted gfp_t [usertype] flags
    > > block/genhd.c:659:29: got unsigned int
    > > block: kmalloc args reversed
    >
    > Woops, that kmalloc() is nasty. Thanks a lot, applied to for-2.6.28.

    Umm, the gfp bit sounds like a clear 2.6.27 candidate.


    \
     
     \ /
      Last update: 2008-08-28 16:23    [W:0.018 / U:24.408 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site