[lkml]   [2008]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 08/59] CRED: Wrap task credential accesses in the tty driver
    Wrap access to task credentials so that they can be separated more easily from
    the task_struct during the introduction of COW creds.

    Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

    Change some task->e?[ug]id to task_e?[ug]id(). In some places it makes more
    sense to use RCU directly rather than a convenient wrapper; these will be
    addressed by later patches.

    Signed-off-by: David Howells <>
    Reviewed-by: James Morris <>
    Acked-by: Serge Hallyn <>
    Cc: Alan Cox <>

    drivers/char/tty_audit.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/char/tty_audit.c b/drivers/char/tty_audit.c
    index 3582f43..570d337 100644
    --- a/drivers/char/tty_audit.c
    +++ b/drivers/char/tty_audit.c
    @@ -86,10 +86,12 @@ static void tty_audit_buf_push(struct task_struct *tsk, uid_t loginuid,
    ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_TTY);
    if (ab) {
    char name[sizeof(tsk->comm)];
    + uid_t uid = task_uid(tsk);

    audit_log_format(ab, "tty pid=%u uid=%u auid=%u ses=%u "
    - "major=%d minor=%d comm=", tsk->pid, tsk->uid,
    - loginuid, sessionid, buf->major, buf->minor);
    + "major=%d minor=%d comm=",
    + tsk->pid, uid, loginuid, sessionid,
    + buf->major, buf->minor);
    get_task_comm(name, tsk);
    audit_log_untrustedstring(ab, name);
    audit_log_format(ab, " data=");

     \ /
      Last update: 2008-08-27 15:51    [W:0.021 / U:4.148 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site