lkml.org 
[lkml]   [2008]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] afs: fsclient.c sparse endian annotations of operation_ID
From
From: David Howells <dhowells@redhat.com>
Date: Wed, 27 Aug 2008 12:12:24 +0100

> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > + if (call->operation_ID != __constant_htonl(FSFETCHDATA64)) {
>
> Doesn't htonl() resolve to this for a constant argument? Following through
> the definitions, it certainly looks like it ought to:

Yes it does.

The __constant_*() interfaces should only be uses for things that
must be evaluated at compile time (static data initializations,
switch statement case values etc.).


\
 
 \ /
  Last update: 2008-08-27 13:19    [W:0.049 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site