Messages in this thread | | | Date | Tue, 26 Aug 2008 13:35:35 -0700 | From | Mike Travis <> | Subject | Re: [RFC][PATCH 2/2] quicklist shouldn't be proportional to # of CPUs |
| |
KOSAKI Motohiro wrote: >>> + int node = numa_node_id(); >>> + struct zone *zones = NODE_DATA(node)->node_zones; >>> + int num_cpus_on_node; >>> + node_to_cpumask_ptr(cpumask_on_node, node); >>> >>> node_free_pages = >>> #ifdef CONFIG_ZONE_DMA >>> @@ -38,6 +41,10 @@ static unsigned long max_pages(unsigned >>> zone_page_state(&zones[ZONE_NORMAL], NR_FREE_PAGES); >>> >>> max = node_free_pages / FRACTION_OF_NODE_MEM; >>> + >>> + num_cpus_on_node = cpus_weight_nr(*cpumask_on_node); >>> + max /= num_cpus_on_node; >>> + >>> return max(max, min_pages); >> Exactly! And (many thanks to them!) the sparc maintainers have >> implemented a similar internal function definition for node_to_cpumask_ptr(). > > Can I think get your Ack? >
Based on code review, sure. I'll also give it a try on one of my test machines as soon as I can.
Mike
| |