lkml.org 
[lkml]   [2008]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/9] ide-disk: set_addressing() fixes
    Date
    On Saturday 23 August 2008, Sergei Shtylyov wrote:
    > Hello.
    >
    > Bartlomiej Zolnierkiewicz wrote:
    >
    > > * Return -EIO if arg > 0 and LBA48 is unsupported.
    > >
    > > * No need to reset ->addressing.
    > >
    > > * Make ->addressing a single bit flag.
    > >
    > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    > >
    > [...]
    > > Index: b/include/linux/ide.h
    > > ===================================================================
    > > --- a/include/linux/ide.h
    > > +++ b/include/linux/ide.h
    > > @@ -507,7 +507,7 @@ struct ide_drive_s {
    > > unsigned sleeping : 1; /* 1=sleeping & sleep field valid */
    > > unsigned post_reset : 1;
    > > unsigned udma33_warned : 1;
    > > - unsigned addressing : 2; /* 0=28-bit, 1=48-bit, 2=48-bit doing 28-bit */
    > > + unsigned addressing : 1; /* 0=28-bit, 1=48-bit */
    > > unsigned wcache : 1; /* status of write cache */
    > > unsigned nowerr : 1; /* used for ignoring ATA_DF */
    > >
    >
    > Don't you want to get rid of things like:
    >
    > u8 lba48 = (drive->addressing == 1) ? 1 : 0;

    This was dealt with in "[PATCH 5/9] ide: add device flags" - since patch
    #5/9 was going to touch the code anyway and there were no benefits besides
    aesthetics in doing it in #2/9 I optimized the development process a bit...


    \
     
     \ /
      Last update: 2008-08-25 22:35    [W:0.023 / U:31.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site