Messages in this thread | | | Date | Fri, 22 Aug 2008 14:20:40 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 1/6] ide: set IDE_AFLAG_DRQ_INTERRUPT in do_identify() |
| |
Hello.
Bartlomiej Zolnierkiewicz wrote:
> Set IDE_AFLAG_DRQ_INTERRUPT in do_identify() instead of ATAPI > device drivers *_setup() methods. > > While at it: > - use ata_id_cdb_intr() > > There should be no functional changes caused by this patch. > > Cc: Borislav Petkov <petkovbb@gmail.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > [...] > Index: b/drivers/ide/ide-cd.c > =================================================================== > --- a/drivers/ide/ide-cd.c > +++ b/drivers/ide/ide-cd.c > @@ -1887,9 +1887,6 @@ static int ide_cdrom_setup(ide_drive_t * > drive->atapi_flags = IDE_AFLAG_MEDIA_CHANGED | IDE_AFLAG_NO_EJECT | > ide_cd_flags(id); > > - if ((id[ATA_ID_CONFIG] & 0x0060) == 0x20) > - drive->atapi_flags |= IDE_AFLAG_DRQ_INTERRUPT; > - >
Wait, this needs to be fixed first -- 0x20 does *not* mean CDB INTRQ!
> Index: b/drivers/scsi/ide-scsi.c > =================================================================== > --- a/drivers/scsi/ide-scsi.c > +++ b/drivers/scsi/ide-scsi.c > @@ -385,8 +385,6 @@ static const struct ide_proc_devset ides > */ > static void idescsi_setup (ide_drive_t *drive, idescsi_scsi_t *scsi) > { > - if ((drive->id[ATA_ID_CONFIG] & 0x0060) == 0x20) >
This one is wrong too...
WBR, Sergei
| |