Messages in this thread | | | Date | Fri, 22 Aug 2008 14:10:45 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v6) |
| |
> User-Agent: Thunderbird 2.0.0.16 (X11/20080707)
uh-oh.
On Tue, 19 Aug 2008 20:01:22 -0700 Philip Langdale <philipl@overt.org> wrote:
> There's been a patch floating around for toshiba_acpi that exports an ad-hoc > /proc interface to toggle the bluetooth adapter in a large number of Toshiba > laptops. I'm not sure if it's still relevant for the latest models, but it is > still required for older models such as my Tecra M3. > > This change pulls in the low level Toshiba-specific code from the old patch and > sets up an rfkill device and a polled input device to track the state of the > hardware kill-switch. > > Signed-off-by: Philip Langdale <philipl@overt.org> > --- > Kconfig | 1 > toshiba_acpi.c | 263 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 735f5ea..047829c 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -260,6 +260,7 @@ config ACPI_ASUS > config ACPI_TOSHIBA > tristate "Toshiba Laptop Extras" > depends on X86 > + select INPUT_POLLDEV > select BACKLIGHT_CLASS_DEVICE > ---help--- > This driver adds support for access to certain system settings > diff --git a/drivers/acpi/toshiba_acpi.c b/drivers/acpi/toshiba_acpi.c > index 0a43c8e..5723019 100644 > --- a/drivers/acpi/toshiba_acpi.c > +++ b/drivers/acpi/toshiba_acpi.c > @@ -3,6 +3,7 @@ > * > * > * Copyright (C) 2002-2004 John Belmonte > + * Copyright (C) 2008 Philip Langdale
your email client is performing space-stuffing. Please see Documentation/email-clients.txt.
Please pass the patch through scripts/checkpatch.pl. It finds a large number of errors.
Please consistently put a single blank line between end-of-locals and start-of-code. Avoid randomness like:
> +static void bt_poll_rfkill(struct input_polled_dev *poll_dev) > +{ > + bool state_changed; > + bool new_rfk_state; > + bool value; > + u32 hci_result; > + > + struct toshiba_acpi_dev *dev = poll_dev->private; > + > + hci_result = hci_get_radio_state(&value); >
The code uses new-style `bool' but it also adds at least one usage of the old-style `FALSE'.
| |