Messages in this thread | | | Date | Thu, 21 Aug 2008 16:31:31 +0900 | From | "KOSAKI Motohiro" <> | Subject | Re: [RFC][PATCH 2/2] quicklist shouldn't be proportional to # of CPUs |
| |
>> IA64 seems to be one of the few platforms to define this as a macro >> evaluating to the node-to-cpumask array entry, so it's clear what >> platform Motohiro-san did build testing on :-) > > Seems to compile OK on x86_32, x86_64, ia64 and powerpc for some reason. > > This seems to fix things on sparc64: > > --- a/mm/quicklist.c~mm-quicklist-shouldnt-be-proportional-to-number-of-cpus-fix > +++ a/mm/quicklist.c > @@ -28,7 +28,7 @@ static unsigned long max_pages(unsigned > unsigned long node_free_pages, max; > int node = numa_node_id(); > struct zone *zones = NODE_DATA(node)->node_zones; > - int num_cpus_per_node; > + cpumask_t node_cpumask; > > node_free_pages = > #ifdef CONFIG_ZONE_DMA > @@ -41,8 +41,8 @@ static unsigned long max_pages(unsigned > > max = node_free_pages / FRACTION_OF_NODE_MEM; > > - num_cpus_per_node = cpus_weight_nr(node_to_cpumask(node)); > - max /= num_cpus_per_node; > + node_cpumask = node_to_cpumask(node); > + max /= cpus_weight_nr(node_cpumask); > > return max(max, min_pages); > }
Thank you!!
| |