lkml.org 
[lkml]   [2008]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 6/8] Revert "netns: Fix device renaming for sysfs"
    From
    From: ebiederm@xmission.com (Eric W. Biederman)
    Date: Wed, 20 Aug 2008 23:38:31 -0700

    >
    > This reverts commit aaf8cdc34ddba08122f02217d9d684e2f9f5d575.
    >
    > Drivers like the ipw2100 call device_create_group when they
    > are initialized and device_remove_group when they are shutdown.
    > Moving them between namespaces deletes their sysfs groups early.
    >
    > In particular the following call chain results.
    > netdev_unregister_kobject -> device_del -> kobject_del -> sysfs_remove_dir
    > With sysfs_remove_dir recursively deleting all of it's subdirectories,
    > and nothing adding them back.
    >
    > Ouch!
    >
    > Therefore we need to call something that ultimate calls sysfs_mv_dir
    > as that sysfs function can move sysfs directories between namespaces
    > without deleting their subdirectories or their contents. Allowing
    > us to avoid placing extra boiler plate into every driver that does
    > something interesting with sysfs.
    >
    > Currently the function that provides that capability is device_rename.
    > That is the code works without nasty side effects as originally written.
    >
    > So remove the misguided fix for moving devices between namespaces. The
    > bug in the kobject layer that inspired it has now been recognized and
    > fixed.
    >
    > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

    Acked-by: David S. Miller <davem@davemloft.net>


    \
     
     \ /
      Last update: 2008-08-21 08:51    [W:0.030 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site