lkml.org 
[lkml]   [2008]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [3/4] add agp_generic_destroy_pages()

* Andrew Morton <akpm@linux-foundation.org> wrote:

> stylistic nit:
>
> > +
> > + for (i = 0; i < curr->page_count; i++) {
> > + curr->memory[i] = (unsigned long)gart_to_virt(
> > + curr->memory[i]);
> > + curr->bridge->driver->agp_destroy_page(
> > + (void *)curr->memory[i],
> > + AGP_PAGE_DESTROY_UNMAP);
> > + }
> > + for (i = 0; i < curr->page_count; i++) {
> > + curr->bridge->driver->agp_destroy_page(
> > + (void *)curr->memory[i],
> > + AGP_PAGE_DESTROY_FREE);
> > + }
>
> Make the above code a standalone function and call it here.
>
> Then convert all drivers over so their .agp_destroy_pages points at
> that new function.
>
> Then remove the `if'.

good point.

[ Shaohua, when you fix this, please do it as a delta patch against your
current patchset (or against tip/master). Thanks. ]

Ingo


\
 
 \ /
  Last update: 2008-08-21 13:53    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site