Messages in this thread Patch in this message | | | Date | Sat, 2 Aug 2008 17:15:05 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH 7/10] drivers/net/wan: Use DIV_ROUND_UP |
| |
From: Julia Lawall <julia@diku.dk>
The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / (d)) but is perhaps more readable.
An extract of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl> @haskernel@ @@
#include <linux/kernel.h>
@depends on haskernel@ expression n,d; @@
( - (n + d - 1) / d + DIV_ROUND_UP(n,d) | - (n + (d - 1)) / d + DIV_ROUND_UP(n,d) )
@depends on haskernel@ expression n,d; @@
- DIV_ROUND_UP((n),d) + DIV_ROUND_UP(n,d)
@depends on haskernel@ expression n,d; @@
- DIV_ROUND_UP(n,(d)) + DIV_ROUND_UP(n,d) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/net/wan/sbni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/net/wan/sbni.c b/drivers/net/wan/sbni.c --- a/drivers/net/wan/sbni.c +++ b/drivers/net/wan/sbni.c @@ -856,7 +856,7 @@ prepare_to_send( struct sk_buff *skb, len = SBNI_MIN_LEN; nl->tx_buf_p = skb; - nl->tx_frameno = (len + nl->maxframe - 1) / nl->maxframe; + nl->tx_frameno = DIV_ROUND_UP(len, nl->maxframe); nl->framelen = len < nl->maxframe ? len : nl->maxframe; outb( inb( dev->base_addr + CSR0 ) | TR_REQ, dev->base_addr + CSR0 );
| |