Messages in this thread | | | Date | Sun, 3 Aug 2008 11:42:18 +1000 | From | Dave Chinner <> | Subject | Re: [patch 15/19] Filesystem: XFS slab defragmentation |
| |
On Fri, May 09, 2008 at 07:21:16PM -0700, Christoph Lameter wrote: > Support inode defragmentation for xfs > > Reviewed-by: Rik van Riel <riel@redhat.com> > Signed-off-by: Christoph Lameter <clameter@sgi.com> > Signed-off-by: Christoph Lameter <cl@linux-foundation.org> > > --- > fs/xfs/linux-2.6/xfs_super.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > Index: linux-2.6/fs/xfs/linux-2.6/xfs_super.c > =================================================================== > --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_super.c 2008-07-31 12:18:12.000000000 -0500 > +++ linux-2.6/fs/xfs/linux-2.6/xfs_super.c 2008-07-31 12:18:15.000000000 -0500 > @@ -861,6 +861,7 @@ > xfs_ioend_zone = kmem_zone_init(sizeof(xfs_ioend_t), "xfs_ioend"); > if (!xfs_ioend_zone) > goto out_destroy_vnode_zone; > + kmem_cache_setup_defrag(xfs_vnode_zone, get_inodes, kick_inodes); > > xfs_ioend_pool = mempool_create_slab_pool(4 * MAX_BUF_PER_PAGE, > xfs_ioend_zone);
I think that hunk is mis-applied. You're configuring the xfs_vnode_zone defrag after allocating the xfs_ioend_zone. This should be afew lines higher up, right?
Cheers,
Dave. -- Dave Chinner david@fromorbit.com
| |