Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] ide-generic: skip automatic probing of legacy iobases (was: Re: [PATCH] ide-floppy fix) | Date | Sat, 2 Aug 2008 20:46:16 +0200 |
| |
On Saturday 02 August 2008, Borislav Petkov wrote: > On Sat, Aug 02, 2008 at 07:02:12PM +0200, Bartlomiej Zolnierkiewicz wrote:
[...]
> > > As a result, i have now a new bool-Kconfig option BLK_DEV_GENERIC_ONLY which > > > gets reverse-selected only when no pci ide controller which is using the generic > > > ide_host_register() from within ide_pci_init_one() is selected in Kconfig. This > > > is tested both with and without a pci ide driver selected in addition to > > > ide-generic. > > > > How's about just leaving the final decision up to the user with changing > > probe_mask in ide_generic from 0x3 to 0x0 and automatically probing for > > ports 0-1 iff there is no IDE PCI controller present (otherwise check > > probe_mask). > > Wait, let me get this straight: you want to set probe_mask to 0x0 as a default, > which skips probing of the primary and secondary ports, and to do the checking
Yes.
> whether the IDE PCI controller uses legacy iobases only when the user has > enforced it by setting probe_mask to 0x3? At least this is how i understand > it...
Nope, always do the checking and if there is no IDE PCI controller do the probing (& if there is IDE PCI controller present check probe_mask bits).
| |