Messages in this thread Patch in this message | | | Date | Tue, 19 Aug 2008 17:27:57 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 0/5] merge io_apic_xx.c -- fix |
| |
On Tue, 19 Aug 2008 17:24:08 -0700 "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
> On Tue, Aug 19, 2008 at 3:21 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: > > On Sat, 16 Aug 2008 15:35:54 +0200 Ingo Molnar wrote: > > > >> > >> * Yinghai Lu <yhlu.kernel@gmail.com> wrote: > >> > >> > merge io_apic_xx.c > >> > > >> > Thanks > >> > >> applied to tip/irq/sparseirq - thanks! > > > > > > Are there patches in the io_apic series to fix these warnings in linux-next?? :: > > > > > > linux-next-20080819/arch/x86/kernel/io_apic_32.c:1539: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64' > > linux-next-20080819/arch/x86/kernel/io_apic_32.c:1540: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64 > > > > > > and > > > > linux-next-20080819/arch/x86/kernel/io_apic_32.c:1539: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64' > > linux-next-20080819/arch/x86/kernel/io_apic_32.c:1540: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64' > > > > No
yes
From: Andrew Morton <akpm@linux-foundation.org>
arch/x86/kernel/io_apic_32.c: In function 'print_local_APIC': arch/x86/kernel/io_apic_32.c:1539: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64' arch/x86/kernel/io_apic_32.c:1540: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'u64'
No need for casting here - we know what type u64 has.
Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> ---
arch/x86/kernel/io_apic_32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN arch/x86/kernel/io_apic_32.c~arch-x86-kernel-io_apic_32c-fix-printk-warnings arch/x86/kernel/io_apic_32.c --- a/arch/x86/kernel/io_apic_32.c~arch-x86-kernel-io_apic_32c-fix-printk-warnings +++ a/arch/x86/kernel/io_apic_32.c @@ -1536,8 +1536,8 @@ __apicdebuginit(void) print_local_APIC(v } icr = apic_icr_read(); - printk(KERN_DEBUG "... APIC ICR: %08x\n", icr); - printk(KERN_DEBUG "... APIC ICR2: %08x\n", icr >> 32); + printk(KERN_DEBUG "... APIC ICR: %08Lx\n", icr); + printk(KERN_DEBUG "... APIC ICR2: %08Lx\n", icr >> 32); v = apic_read(APIC_LVTT); printk(KERN_DEBUG "... APIC LVTT: %08x\n", v); _
| |