lkml.org 
[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 19 Aug 2008 17:23:40 -0400
From"Jon Smirl" <>
SubjectRe: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling
On 8/19/08, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > Shouldn't this be
>  >
>  > >  -       if (client->irq <= NO_IRQ)
>  >
>  > instead of
>
>
> NO_IRQ is obsolete. client->irq != is the test and IRQ numbers are
>  unsigned.

I don't know the status of these platforms....
asm-blackfin/irq.h:#define NO_IRQ ((unsigned int)(-1))
asm-mn10300/irq.h:#define NO_IRQ		INT_MAX
asm-parisc/irq.h:#define NO_IRQ		(-1)

-- 
Jon Smirl
jonsmirl@gmail.com


\
 
 \ /
  Last update: 2008-08-19 23:27    [from the cache]
©2003-2008