lkml.org 
[lkml]   [2008]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] Char: cyclades, remove bogus iomap
On Mon, 18 Aug 2008 14:44:38 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Thu, 14 Aug 2008 18:25:52 +0200
> Jiri Slaby <jirislaby@gmail.com> wrote:
>
> > readl/writel are not expected to accept iomap return value. Replace
> > bogus mapping by standard ioremap.
>
> Confused. What's wrong with doing readl(pci_iomap(...))? There are a
> fair number of drivers doing this..

That was discussed some time ago and we fixed a few then.

There is no guarantee that a platform chooses to implement iomaps such
that an iomap cookie is valid for readl/writel. It happens to work on the
current generic implementation.

Alan


\
 
 \ /
  Last update: 2008-08-18 23:59    [W:4.030 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site