Messages in this thread | | | Date | Mon, 18 Aug 2008 10:22:12 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 0/15] apic: unification series 5 |
| |
Cyrill Gorcunov wrote: > > With this series 32bit code compilation warns: > > arch/x86/kernel/apic_32.c: In function ‘end_local_APIC_setup’: > arch/x86/kernel/apic_32.c:1165: warning: ISO C90 forbids mixed declarations and code > arch/x86/kernel/apic_32.c: In function ‘disconnect_bsp_APIC’: > arch/x86/kernel/apic_32.c:1446: warning: ISO C90 forbids mixed declarations and code > cyrill@lenovo linux-2.6.git $ > > So parenthesis will be needed to eliminate them... but > I think it could be too ugly... need some time to think. > So patches 8/15 and 10/15 sould be not applied for now - just review them. > Thanks for patience! >
Typically, just move the declaration to the top of the function (followed by a blank line.)
-hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |