Messages in this thread | | | Date | Sat, 16 Aug 2008 02:00:57 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] pci: change msi-x vector to 32bit |
| |
On Sat, Aug 16, 2008 at 1:17 AM, Eric W. Biederman <ebiederm@xmission.com> wrote: > "H. Peter Anvin" <hpa@zytor.com> writes: > >> The 28 bits aren't enough, are they: we need domain as well (and surely we can >> have more than 16 domains?) > > The justification is questionable. The fact that the irq number > reported for msi-x vectors is only 16bits is a bug. Everywhere else > in the kernel an irq number is stored in a 32bit field.
they assume irq < 65536?
if use NR_IRQS = NR_VEVTORS * NR_CPUS... 256*1024 ==> .... PROBLEM...
> > We also have a few other bits of craziness in the msix interface. > The entry field in msix_entry is unnecessary.
Agreed. qla will have another copy again.
> > In fact now that we have a linked list of irq entries we stop passing > the structure entirely.
msi_list in dev?
YH
| |