Messages in this thread | | | Date | Fri, 15 Aug 2008 15:48:01 +0200 | From | Ingo Molnar <> | Subject | Re: [patch 8/8] x86: apic - unify init_bsp_APIC |
| |
* Maciej W. Rozycki <macro@linux-mips.org> wrote:
> > If that was the question, the answer would be: to unify apic_32.c > > and apic_64.c we first use tiny little changes to bring the two > > files in sync. Presumably, each such change is a NOP or at least > > very safe - and clearly bisectable in the worst-case. > > If the obfuscation comes from apic_64.c, then the clean-up should be > done in th other direction IMO. Not everything that comes from the > 64-bit variation is better than its 32-bit counterpart.
yeah - in fact for most unifications we did the 32-bit counterpart was the cleaner one. (which is no big surprise, 80%-90% of the x86 Linux use, even today, is on the 32-bit side - so most developers watch that one.)
Ingo
| |