Messages in this thread | | | Date | Thu, 14 Aug 2008 17:05:22 -0400 | From | Jason Baron <> | Subject | Re: [PATCH 1/7] dynamic debug v2 - infrastructure |
| |
On Thu, Aug 14, 2008 at 07:53:48AM -0700, Greg KH wrote: > Also, would it make sense to add a patch like the one below to this > code? It might be nice to know when each module's debugging value is > manually changed by the user for the log files. > > If you like it, I can merge it in the main patch. > > thanks, > > greg k-h > > --- > lib/dynamic_printk.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > --- a/lib/dynamic_printk.c > +++ b/lib/dynamic_printk.c > @@ -288,6 +288,9 @@ static ssize_t pr_debug_write(struct fil > num_enabled++; > dynamic_enabled = DYNAMIC_ENABLED_SOME; > err = 0; > + printk(KERN_DEBUG > + "debugging enabled for module %s", > + elem->name); > } else if (!value && (elem->enable == 1)) { > elem->enable = 0; > num_enabled--; > @@ -304,6 +307,9 @@ static ssize_t pr_debug_write(struct fil > dynamic_enabled = > DYNAMIC_ENABLED_NONE; > err = 0; > + printk(KERN_DEBUG > + "debugging disabled for module " > + "%s", elem->name); > } > } > }
looks good. we might also want to add a message for the cases where are the modules are enabled/disabled too.
thanks,
-Jason
| |