Messages in this thread | | | Subject | Re: [patch 1/3] kmsg: Kernel message catalog macros. | From | Martin Schwidefsky <> | Date | Thu, 14 Aug 2008 19:07:03 +0200 |
| |
On Wed, 2008-08-13 at 14:33 +1000, Rusty Russell wrote: > On Thursday 31 July 2008 02:56:57 Martin Schwidefsky wrote: > > From: Michael Holzheu <holzheu@de.ibm.com> > > From: Martin Schwidefsky <schwidefsky@de.ibm.com> > > > > Introduce a new family of printk macros which prefixes each kmsg message > > with a component name and allows to tag the printk with a message id. > > Can you hash the format string to generate the id? 6 hex digits should be > enough, and your tool can check for clashes. As it's bad form to have > identical strings for different semantics anyway, this seems to make sense.
First, how do you do that with the C preprocessor? Second the kmsg-doc script will check that the message format strings match if a kmsg with a specific id is used in multiple locations.
-- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
| |