lkml.org 
[lkml]   [2008]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Fwd: [Patch 2.6] s390 - Allow ECKD devices to be used with older controllers and emulation
From
Date
On Thu, 2008-08-14 at 01:07 +0200, Frans Pop wrote:
> s390 dasd ECKD drivers issues a Perform Subsystem Function / Prepare
> for Read SubSystem Data with a length of 16.
> However, older hardware and documentation specifies a length of 12
> leading to a possible Incorrect Length indication.
> This patch activates the SLI CCW flag in order to avoid reporting
> the Incorrect Length indication since it is possible that the DASD
> control unit may be expecting a length of 12, not 16.
> -- Ivan Warren (ivan@vmfacility.fr)
>
> diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c index 773b3fe..c4e3935 100644
> --- a/drivers/s390/block/dasd_eckd.c
> +++ b/drivers/s390/block/dasd_eckd.c
> @@ -810,6 +810,7 @@ static int dasd_eckd_read_features(struct dasd_device *device)
> ccw->cmd_code = DASD_ECKD_CCW_PSF;
> ccw->count = sizeof(struct dasd_psf_prssd_data);
> ccw->flags |= CCW_FLAG_CC;
> + ccw->flags |= CCW_FLAG_SLI;
> ccw->cda = (__u32)(addr_t) prssdp;
>
> /* Read Subsystem Data - feature codes */

That makes sense, can I get a signed-off-by for the patch please?

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.




\
 
 \ /
  Last update: 2008-08-14 17:09    [W:0.148 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site