lkml.org 
[lkml]   [2008]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH](retry 3) invalidate caches before going into suspend

* Mark Langsdorf <mark.langsdorf@amd.com> wrote:

> + * Systems without cache can just go into halt.
> + */
> +static void wbinvd_halt(void) {

please put this into a unified include file, and as an inline - there's
just a single callsite. That avoids duplication and also removes a
function.

Also, please run the patch through scripts/checkpatch, it would have
suggested to change this:

> +static void wbinvd_halt(void) {

to:

> +static void wbinvd_halt(void)
> +{

Thanks,

Ingo


\
 
 \ /
  Last update: 2008-08-14 15:53    [W:0.127 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site