Messages in this thread | | | Date | Thu, 14 Aug 2008 15:49:51 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH](retry 3) invalidate caches before going into suspend |
| |
* Mark Langsdorf <mark.langsdorf@amd.com> wrote:
> + * Systems without cache can just go into halt. > + */ > +static void wbinvd_halt(void) {
please put this into a unified include file, and as an inline - there's just a single callsite. That avoids duplication and also removes a function.
Also, please run the patch through scripts/checkpatch, it would have suggested to change this:
> +static void wbinvd_halt(void) {
to:
> +static void wbinvd_halt(void) > +{
Thanks,
Ingo
| |