lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] UBIFS: ensure UBIFS switches to read-only on error
    Date
    From: Adrian Hunter <ext-adrian.hunter@nokia.com>

    UBI transparently handles write errors by automatically copying
    and remapping the affected eraseblock. If UBI is unable to do
    that, for example its pool of eraseblocks reserved for bad block
    handling is empty, then the error is propagated to UBIFS. UBIFS
    must protect the media from falling into an inconsistent state
    by immediately switching to read-only mode. In the case of log
    updates, this was not being done.

    Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
    ---
    fs/ubifs/log.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/fs/ubifs/log.c b/fs/ubifs/log.c
    index 36857b9..e14829e 100644
    --- a/fs/ubifs/log.c
    +++ b/fs/ubifs/log.c
    @@ -317,6 +317,8 @@ int ubifs_add_bud_to_log(struct ubifs_info *c, int jhead, int lnum, int offs)
    return 0;

    out_unlock:
    + if (err != -EAGAIN)
    + ubifs_ro_mode(c, err);
    mutex_unlock(&c->log_mutex);
    kfree(ref);
    kfree(bud);
    --
    1.5.4.1


    \
     
     \ /
      Last update: 2008-08-13 10:47    [W:4.104 / U:1.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site