Messages in this thread |  | | | Date | Wed, 13 Aug 2008 18:25:15 -0700 | | From | Greg KH <> | | Subject | Re: [PATCH 1/7] dynamic debug v2 - infrastructure |
| |
On Wed, Aug 13, 2008 at 04:54:25PM -0700, Greg KH wrote: > On Wed, Aug 13, 2008 at 10:00:47PM +0200, Sam Ravnborg wrote: > > On Tue, Aug 12, 2008 at 08:38:59PM -0700, Greg KH wrote: > > > On Tue, Aug 12, 2008 at 06:16:53PM -0700, Andrew Morton wrote: > > > > On Tue, 12 Aug 2008 18:08:04 -0700 > > > > Greg KH <greg@kroah.com> wrote: > > > > > > > > > On Tue, Aug 12, 2008 at 04:46:19PM -0400, Jason Baron wrote: > > > > > > On Tue, Aug 12, 2008 at 01:09:08PM -0700, Greg KH wrote: > > > > > > > So close, can I have a good changelog comment with the patch so people > > > > > > > know what it is when they look in the logs? > > > > > > > > > > > > > > Care to resend it with that? > > > > > > > > > > > > > > > > > > > Base infrastructure to enable per-module debug messages. > > > > > > > > > > Ah, so close... > > > > > > > > > > With this patch, I get the following build error: > > > > > > > > > > CC [M] drivers/usb/gadget/u_ether.o > > > > > drivers/usb/gadget/u_ether.c: In function ___gether_setup___: > > > > > drivers/usb/gadget/u_ether.c:787: error: ___KBUILD_MODNAME___ undeclared (first use in this function) > > > > > drivers/usb/gadget/u_ether.c:787: error: (Each undeclared identifier is reported only once > > > > > drivers/usb/gadget/u_ether.c:787: error: for each function it appears in.) > > > > > drivers/usb/gadget/u_ether.c:787: error: unknown field ___Usage___ specified in initializer > > > > > drivers/usb/gadget/u_ether.c:787: error: expected expression before ___.___ token > > > > > drivers/usb/gadget/u_ether.c:787: error: initializer element is not constant > > > > > drivers/usb/gadget/u_ether.c:787: error: (near initialization for ___descriptor.hash___) > > > > > drivers/usb/gadget/u_ether.c:787: error: ___Usage___ undeclared (first use in this function) > > > > > drivers/usb/gadget/u_ether.c:787: error: invalid operands to binary << (have ___long long int___ and ___char *___) > > > > > drivers/usb/gadget/u_ether.c:787: error: expected ___)___ before ___:___ token > > > > > drivers/usb/gadget/u_ether.c:787: error: invalid operands to binary & (have ___long long int___ and ___char *___) > > > > > drivers/usb/gadget/u_ether.c:787: error: invalid operands to binary << (have ___long long int___ and ___char *___) > > > > > drivers/usb/gadget/u_ether.c:787: error: expected ___)___ before ___:___ token > > > > > drivers/usb/gadget/u_ether.c:787: error: invalid operands to binary & (have ___long long int___ and ___char *___) > > > > > drivers/usb/gadget/u_ether.c:787: error: expected ___)___ before ___:___ token > > > > > drivers/usb/gadget/u_ether.c:787: warning: passing argument 4 of _____dynamic_dbg_enabled_helper___ makes integer from pointer without a cast > > > > > drivers/usb/gadget/u_ether.c:787: error: expected ___)___ before ___KBUILD_MODNAME___ > > > > > > > > (lol at gcc crap) > > > > > > > > > drivers/usb/gadget/u_ether.c:787: warning: too few arguments for format > > > > > > > > argh, not that again. We had this with a patch from Jesse a while > > > > back, which I fixed thusly: > > > > > > <patch moving KBUILD_MODNAME from a inline function to a macro snipped> > > > > > > Yeah, I remember that too, but in this case, KBUILD_MODNAME is being > > > used in a macro, not an inline function, the exact opposite. > > > > > > Sam, any ideas here? I'll bounce the original patch at you if you > > > missed it last time. > > > > I have not looked into the particular error but what happens is > > that u_ether.o is used by more than one module so kbuild does > > not know what value to assign the KBUILD_MODNAME and therefore > > decide not to assign KBUILD_MODNAME at all. > > Ick. > > Hm, how do I fix this? Build u_ether.c into two different .o files, > depending on which module it is being included into? > > Or do: > #include "u_ether.c" > in the source code that was linking it in? > > Actually, as ugly as that last one is, it probably would solve this > issue, and be the same end-result, right?
Argh, that code is just horrible!!!
I'll go split this up into separate sub-modules, like it really needs to be. That will solve this problem.
Bah, why do people make things so hard...
thanks,
greg k-h
|  |