lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 13 Aug 2008 16:45:03 -0700
FromGreg KH <>
SubjectRe: [PATCH 01/01][retry 2] x86: L3 cache index disable for 2.6.26
On Wed, Aug 13, 2008 at 03:02:42PM -0500, Mark Langsdorf wrote:
> +#if defined(CONFIG_PCI) && defined(CONFIG_K8_NB)
> +#include <linux/pci.h>

Not needed to be hid behind a #if.

> +#include <asm/k8.h>

#includes go at the top of files.

> +static struct pci_dev *get_k8_northbridge(int node)
> +{
> + return k8_northbridges[node];
> +}
> +#else
> +static inline int pci_write_config_dword(struct pci_dev *dev, int where,
> + u32 val)

Don't redefine these common functions, pci.h will handle this properly
if for some reason CONFIG_PCI is not enabled.

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-08-14 01:57    [from the cache]
©2003-2010