lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [ProbableSpam]Re: [PATCH 2/5] Container Freezer: Make refrigerator always available
    Date
    On Wednesday, 13 of August 2008, Matt Helsley wrote:
    >
    > On Tue, 2008-08-12 at 22:49 +0200, Rafael J. Wysocki wrote:
    > > On Tuesday, 12 of August 2008, Matt Helsley wrote:
    > > > Now that the TIF_FREEZE flag is available in all architectures,
    > > > extract the refrigerator() and freeze_task() from kernel/power/process.c
    > > > and make it available to all.
    > > >
    > > > The refrigerator() can now be used in a control group subsystem
    > > > implementing a control group freezer.
    > > >
    > > > Signed-off-by: Cedric Le Goater <clg@fr.ibm.com>
    > > > Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
    > > > Acked-by: Serge E. Hallyn <serue@us.ibm.com>
    > > > Tested-by: Matt Helsley <matthltc@us.ibm.com>
    > >
    > > Your Signed-off-by implies your Tested-by (at least it should ;-)).
    >
    > I wasn't sure that was always true so I added it just in case. I'll take
    > it out of any future postings.
    >
    > > > ---
    > > [--snip--]
    > > > Index: linux-2.6.27-rc1-mm1/kernel/power/Kconfig
    > > > ===================================================================
    > > > --- linux-2.6.27-rc1-mm1.orig/kernel/power/Kconfig
    > > > +++ linux-2.6.27-rc1-mm1/kernel/power/Kconfig
    > > > @@ -85,6 +85,9 @@ config PM_SLEEP
    > > > depends on SUSPEND || HIBERNATION || XEN_SAVE_RESTORE
    > > > default y
    > > >
    > > > +config FREEZER
    > > > + def_bool PM_SLEEP
    > > > +
    > >
    > > I'd still prefer this to go into a Kconfig in the parent directory (ie. where
    > > freezer.c and the Makefile building it are located). Otherwise it's guaranteed
    > > to confuse someone.
    >
    > I'm thinking of making a patch moving the cgroups config variables into
    > a kernel/Kconfig.cgroups file. Would moving config FREEZER to such a
    > file be satisfactory? Paul, what do you think?

    Well, in fact FREEZER is not directly dependent on cgroups, as it can also
    depend on PM_SLEEP, even if cgroups are not used at all.

    I would just add 'Kconfig.freezer' to 'kernel', put 'config FREEZER' in there
    and make it depend on whatever needs it. Of course,
    'source "kernel/Kconfig.freezer"' would have to be added to top-level
    Kconfigs for all architectures, but please note that only a few architectures
    include 'kernel/power/Kconfig', so you'd have to change the top-level
    Kconfigs anyway.

    Alternatively, you can just add 'config FREEZER' directly to the top-level
    Kconfigs.

    Thanks,
    Rafael


    \
     
     \ /
      Last update: 2008-08-13 20:41    [W:0.026 / U:177.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site