lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kexec jump: fix compiling warning on xchg(&kexec_lock, 0) in kernel_kexec()


On Wed, 13 Aug 2008, Huang Ying wrote:
>
> - xchg(&kexec_lock, 0);
> + locked = xchg(&kexec_lock, 0);
> + BUG_ON(!locked);

Why do you want to do this at all?

And why do you implement your locks with xchg() in the first place? That's
total and utter crap.

Hint: we have _real_ locking primitives in the kernel.

Linus


\
 
 \ /
  Last update: 2008-08-13 19:01    [W:0.082 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site