Messages in this thread | | | Date | Wed, 13 Aug 2008 11:17:41 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] Propagate new nonpanic bootmem macros to CONFIG_HAVE_ARCH_BOOTMEM_NODE |
| |
* Johannes Weiner <hannes@saeurebad.de> wrote:
> Hi Ingo, > > Ingo Molnar <mingo@elte.hu> writes: > > > * Jan Beulich <jbeulich@novell.com> wrote: > > > >> Sorry for not noticing this: > >> Acked-by: Jan Beulich <jbeulich@novell.com> > >> > >> >>> Johannes Weiner <hannes@saeurebad.de> 13.08.08 10:17 >>> > >> Commit 74768ed833344b "page allocator: use no-panic variant of > >> alloc_bootmem() in alloc_large_system_hash()" introduced two new > >> _nopanic macros which are undefined for CONFIG_HAVE_ARCH_BOOTMEM_NODE. > >> > >> Signed-off-by: Johannes Weiner <hannes@saeurebad.de> > > > > btw., i dont think the fix is complete, a quick grep shows: > > > > arch/avr32/Kconfig:config HAVE_ARCH_BOOTMEM_NODE > > Uhm, I think a fix for that would be removing the knob from the avr32 > Kconfig. It defaults to n and I couldn't find a place where this gets > enabled. > > Furthermore, there doesn't seem to be any arch-specific code > associated with it (grep -R ARCH_BOOTMEM_NODE arch/avr32).
ok, indeed. I dont think it should be removed: it makes sense for an architecture to list all Kconfig knobs that _might_ matter - even if they are disabled for an architecture.
That makes it easier to know whether a Kconfig knob that is disables is disabled because the arch wants it disabled, because the arch wants it enabled, or because it's a knew knob the arch does not know about yet. So it's 3 states really.
Ingo
| |