Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [PATCH 2/2] CRED: Introduce credential access wrappers | Date | Tue, 12 Aug 2008 21:02:14 +0200 |
| |
Hi David,
On Tuesday 12 August 2008, David Howells wrote: > Wrappers are introduced into a new header (linux/cred.h) for UID/GID, > EUID/EGID, SUID/SGID, FSUID/FSGID, cap_effective and current's subscribed > user_struct.
Why macros? When introducing APIs using trivial inlines makes sure that the conversion is correct, type correct and side effect free for the callers. Macros cannot ensure this without pain.
Please respin this patch with inlines. If that needs header changes, your CRED subsytem might need that, too.
Best Regards
Ingo Oeser
| |