lkml.org 
[lkml]   [2008]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] CRED: Introduce credential access wrappers
Date
Hi David,

On Tuesday 12 August 2008, David Howells wrote:
> Wrappers are introduced into a new header (linux/cred.h) for UID/GID,
> EUID/EGID, SUID/SGID, FSUID/FSGID, cap_effective and current's subscribed
> user_struct.

Why macros? When introducing APIs using trivial inlines makes sure that
the conversion is correct, type correct and side effect free for the callers.
Macros cannot ensure this without pain.

Please respin this patch with inlines. If that needs header changes,
your CRED subsytem might need that, too.


Best Regards

Ingo Oeser


\
 
 \ /
  Last update: 2008-08-12 21:11    [W:0.044 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site