Messages in this thread | | | Date | Tue, 12 Aug 2008 19:06:58 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH 0/7] x86 dma_*_coherent rework patchset |
| |
[added Andi to CC]
On Tue, Aug 12, 2008 at 05:24:10PM +0200, Joerg Roedel wrote: > Hi, > > this patchset reworks the dma_*_coherent functions in the DMA layer > for the x86 architecture. The patch series extends the existing DMA > backends with missing *coherent callbacks and simplifies the generic > function to basically only call the registered backend. This allows > future optimizations in hardware specific IOMMU implementations. > The code ist tested on AMD64 with AMD IOMMU and GART as well as on > my old 486 box. It is not yet tested on a Calgary IOMMU system.
Now it is---appears to work fine on a Calgary system.
In general the patchset looks good and is definitely a step in the right direction. I am a bit concerned about the contortions that the generic dma_alloc_coherent went through before calling the ops version---have you verified they are no longer needed?
Cheers, Muli -- Workshop on I/O Virtualization (WIOV '08) Co-located with OSDI '08, Dec 2008, San Diego, CA http://www.usenix.org/wiov08
| |