lkml.org 
[lkml]   [2008]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectPossible false positive in checkpatch
    The following appears to be a false positive in checkpatch:

    ERROR: space prohibited after that '*' (ctx:BxW)
    #163: FILE: drivers/usb/core/usb.c:304:
    +#define usb_device_pm_ops (* (struct pm_ops *) 0)
    ^

    Certainly this is a rather uncommon code construction, but similar
    ones might occur elsewhere. To my eyes,

    (* (type *) ptr)

    looks better than

    (*(type *) ptr)

    or

    (*(type *)ptr)

    or even

    (*(type*)ptr)

    but of course this is a matter of opinion. Is there any strong feeling
    about this in the kernel community?

    Alan Stern



    \
     
     \ /
      Last update: 2008-08-12 16:27    [W:0.020 / U:0.580 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site