lkml.org 
[lkml]   [2008]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpuset: Rework sched domains and CPU hotplug handling (take 4)
On 8/12/08, Rakib Mullick <rakib.mullick@gmail.com> wrote:
> On 8/12/08, Max Krasnyansky <maxk@qualcomm.com> wrote:
>
> > Rakib Mullick wrote:
> > > One more thing Max, while you are allocating memory for "dattr" I
> > > think it needs to check that it is successful or not . I've shown it
> > > on one of my previous patch on 7th Aug.
> >
> >
> > I think you missed this part of the patch
> >
> >
> > > + /*
> > > + * The rest of the code, including the scheduler, can deal with
> > > + * dattr==NULL case. No need to abort if alloc fails.
> > > + */
> > > dattr = kmalloc(ndoms * sizeof(struct sched_domain_attr), GFP_KERNEL);
> >
> >
> > I replied to your patch saying that we do not need to check it. And Paul
> > suggested to add a comment to explain why.
>
Ok, this is the second place. But, what about the first place ( I
mean in line 614).
> >
> >
> > Max
> >
> >
> >
>


\
 
 \ /
  Last update: 2008-08-12 15:51    [W:0.060 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site