Messages in this thread | | | Subject | Re: [ipw3945-devel] [PATCH 1/1] iwlwifi: fix printk newlines | From | Zhu Yi <> | Date | Tue, 12 Aug 2008 09:22:17 +0800 |
| |
On Tue, 2008-08-12 at 02:55 +0200, Marcel Holtmann wrote: > > s = iwl4965_get_sub_band(priv, channel); > > if (s >= EEPROM_TX_POWER_BANDS) { > > - IWL_ERROR("Tx Power can not find channel %d ", > channel); > > + IWL_ERROR("Tx Power can not find channel %d\n", > channel); > > return -1; > > } > > can we not just fix IWL_ERROR to always append the newline?
We should give the users more control to the style I think.
Thanks, -yi
| |