Messages in this thread | | | Date | Mon, 11 Aug 2008 20:41:22 -0400 | From | Brian Haley <> | Subject | Re: OOPS, ip -f inet6 route get fec0::1, linux-2.6.26, ip6_route_output, rt6_fill_node+0x175 |
| |
Eugene Teo wrote: > I think it's better to use a helper routine like ipv6_get_saddr to make > sure that both dst and rt6i_idev arguments are checked for NULL. > > I have compiled, and tested the patch. > > Thanks, > Eugene > > --- > Fix NULL pointer dereference in rt6_fill_node(). > > # ip -f inet6 route get fec0::1 > > BUG: unable to handle kernel NULL pointer dereference at 00000000 > IP: [<c0369b85>] rt6_fill_node+0x175/0x3b0 > EIP is at rt6_fill_node+0x175/0x3b0 > > Cc: Stable <stable@kernel.org> > Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
Acked-by: Brian Haley <brian.haley@hp.com>
But Yoshfuji might have another opinion since he did the work to remove ipv6_get_saddr() in the first place.
-Brian
| |