lkml.org 
[lkml]   [2008]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/17] checkpatch: fix up comment checks search to scan the entire block
    Date
    We are not counting the lines in the block correctly which causes the
    comment scan to stop prematurly and thus miss comments which end at the
    end of the block. Fix this up.

    Signed-off-by: Andy Whitcroft <apw@shadowen.org>
    ---
    scripts/checkpatch.pl | 11 ++++++++---
    1 files changed, 8 insertions(+), 3 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index 586f9a4..482768c 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -1029,9 +1029,14 @@ sub process {
    # edge is a close comment then we must be in a comment
    # at context start.
    my $edge;
    - for (my $ln = $linenr + 1; $ln < ($linenr + $realcnt); $ln++) {
    - next if ($line =~ /^-/);
    - ($edge) = ($rawlines[$ln - 1] =~ m@(/\*|\*/)@);
    + my $cnt = $realcnt;
    + for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
    + next if (defined $rawlines[$ln - 1] &&
    + $rawlines[$ln - 1] =~ /^-/);
    + $cnt--;
    + #print "RAW<$rawlines[$ln - 1]>\n";
    + ($edge) = (defined $rawlines[$ln - 1] &&
    + $rawlines[$ln - 1] =~ m@(/\*|\*/)@);
    last if (defined $edge);
    }
    if (defined $edge && $edge eq '*/') {
    --
    1.6.0.rc1.258.g80295


    \
     
     \ /
      Last update: 2008-08-11 22:19    [W:0.023 / U:61.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site