Messages in this thread Patch in this message | | | From | Andy Whitcroft <> | Subject | [PATCH 04/17] checkpatch: switch indent allow plain return | Date | Mon, 11 Aug 2008 21:12:59 +0100 |
| |
It is a common and sane idiom to allow a single return on the end of a case statement:
switch (...) { case foo: return bar; }
Add an exception for this.
Signed-off-by: Andy Whitcroft <apw@shadowen.org> --- scripts/checkpatch.pl | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 1e7d2cd..c6782ac 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1295,7 +1295,11 @@ sub process { } } if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g && - $line !~ /\G(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$/g) { + $line !~ /\G(?: + (?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$| + \s*return\s+ + )/xg) + { ERROR("trailing statements should be on next line\n" . $herecurr); } -- 1.6.0.rc1.258.g80295
| |