lkml.org 
[lkml]   [2008]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Resurect proper handling of maxcpus= kernel option

* Max Krasnyansky <maxk@qualcomm.com> wrote:

> > This will need some test time on 32-bit as that is where this
> > represents a material change. ( albeit what matters most is the
> > maxcpus=1 distinction - and for that nosmp can be used as well to
> > turn off multi-cpu support altogether. So we could do this in
> > v2.6.27 as well. )
>
> So far we got a couple of reports that it works as expected on 32
> (both laptop and server/desktop).

Yes, but the usecase i'm worried about is when say maxcpus=1 was used to
_prevent_ an SMP bootup - because the system would not work otherwise.

i guess we want to tickle those systems anyway as that case is not
supposed to happen (and it can always be totally disabled via nosmp or
noapic).

So i'm not against your fix/change per se, i just wanted to highlight
that it has some impact on existing uses of maxcpus that is outside of
your cpu-hotplug usecase.

Ingo


\
 
 \ /
  Last update: 2008-08-11 20:41    [from the cache]
©2003-2011 Jasper Spaans