lkml.org 
[lkml]   [2008]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectCheckpatch false positive?
    From
    Date
    Hello checkpatch.pl maintainers,

    I'm adding a new thread flag and I get this apparent checkpatch false
    positive:


    ERROR: do not modify files in include/asm, change architecture specific files in include/asm-<architecture>
    #36: +++ linux-2.6.27-rc1-mm1/arch/sparc/include/asm/thread_info_32.h

    ERROR: do not modify files in include/asm, change architecture specific files in include/asm-<architecture>
    #63: +++ linux-2.6.27-rc1-mm1/arch/sparc/include/asm/thread_info_64.h

    ERROR: do not modify files in include/asm, change architecture specific files in include/asm-<architecture>
    #289: +++ linux-2.6.27-rc1-mm1/arch/parisc/include/asm/thread_info.h

    patches/0001-Container-Freezer-Add-TIF_FREEZE-flag-to-all-archit.patch total: 3 errors, 0 warnings, 214 lines checked

    patches/0001-Container-Freezer-Add-TIF_FREEZE-flag-to-all-archit.patch has style problems, please review. If any of these errors
    are false positives report them to the maintainer, see
    CHECKPATCH in MAINTAINERS.


    Which happens for every arch where the file has been moved under the
    arch/ directory (sparc and parisc so far). Should this check for
    arch/<foo>/include/asm before giving an ERROR? Should
    arch/<foo>/include/asm only trigger a WARNING in this case?

    Cheers,
    -Matt Helsley



    \
     
     \ /
      Last update: 2008-08-01 06:53    [W:0.028 / U:62.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site