lkml.org 
[lkml]   [2008]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/4] MFD: Remove unnecessary fields if mfd_cell structure.
2008/7/9 Ben Dooks <ben-linux@fluff.org>:
> The enable,disable,suspend and resume entry in the struct mfd_cell
> do not seem to be necessary as they should be handled by the
> platform driver that the device created has bound to.

NAK. It's used e.g. by the tmio-nand driver. These fields provide easy
way to support
enhanced power management, etc.

>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> Index: linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h
> ===================================================================
> --- linux-2.6.26-rc9-next20080709.orig/include/linux/mfd/core.h 2008-07-09 10:44:45.000000000 +0100
> +++ linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h 2008-07-09 10:45:06.000000000 +0100
> @@ -23,12 +26,6 @@
> */
> struct mfd_cell {
> const char *name;
> -
> - int (*enable)(struct platform_device *dev);
> - int (*disable)(struct platform_device *dev);
> - int (*suspend)(struct platform_device *dev);
> - int (*resume)(struct platform_device *dev);
> -
> void *driver_data; /* driver-specific data */
>
> /*
>
> --
>



--
With best wishes
Dmitry


\
 
 \ /
  Last update: 2008-07-09 13:11    [W:0.114 / U:1.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site