lkml.org 
[lkml]   [2008]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 17/34] AMD IOMMU: add generic defines and structures for mapping code
    On Thu, 26 Jun 2008 21:27:53 +0200 Joerg Roedel <joerg.roedel@amd.com> wrote:

    > This patch adds generic stuff used by the mapping and unmapping code for the
    > AMD IOMMU.
    >
    > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
    > ---
    > arch/x86/kernel/amd_iommu.c | 40 ++++++++++++++++++++++++++++++++++++++++
    > 1 files changed, 40 insertions(+), 0 deletions(-)
    > create mode 100644 arch/x86/kernel/amd_iommu.c
    >
    > diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
    > new file mode 100644
    > index 0000000..90392c7
    > --- /dev/null
    > +++ b/arch/x86/kernel/amd_iommu.c
    > @@ -0,0 +1,40 @@
    > +/*
    > + * Copyright (C) 2007-2008 Advanced Micro Devices, Inc.
    > + * Author: Joerg Roedel <joerg.roedel@amd.com>
    > + * Leo Duran <leo.duran@amd.com>
    > + *
    > + * This program is free software; you can redistribute it and/or modify it
    > + * under the terms of the GNU General Public License version 2 as published
    > + * by the Free Software Foundation.
    > + *
    > + * This program is distributed in the hope that it will be useful,
    > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
    > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    > + * GNU General Public License for more details.
    > + *
    > + * You should have received a copy of the GNU General Public License
    > + * along with this program; if not, write to the Free Software
    > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
    > + */
    > +
    > +#include <linux/pci.h>
    > +#include <linux/gfp.h>
    > +#include <linux/bitops.h>
    > +#include <linux/scatterlist.h>
    > +#include <linux/iommu-helper.h>
    > +#include <asm/proto.h>
    > +#include <asm/gart.h>
    > +#include <asm/amd_iommu_types.h>
    > +
    > +#define CMD_SET_TYPE(cmd, t) ((cmd)->data[1] |= ((t) << 28))

    Doesn't need to be implemented in a macro, hence should be implemented in C,
    please.

    > +#define to_pages(addr, size) \
    > + (round_up(((addr) & ~PAGE_MASK) + (size), PAGE_SIZE) >> PAGE_SHIFT)

    Does this patchset add any comments *at all*? Is it really all so obvious
    that this was justifiable?

    I don't know what this function does, but it shouldn't be doing it here.
    Either it duplicates an existing helper or it should be implemented in mm.h

    Preferably not as a macro.

    Preferably with some documentation.

    It is unobvious whether this haler has correct behaviour with all mixes of
    32-bit and 64-bit signed and unsigned types.

    > +static DEFINE_RWLOCK(amd_iommu_devtable_lock);
    > +
    > +struct command {
    > + u32 data[4];
    > +};

    Nothing in this file is used by anything. I assume that later patches add
    stuff to it. This made it a bit hard to review.


    \
     
     \ /
      Last update: 2008-07-10 04:11    [W:4.088 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site