Messages in this thread | | | Date | Thu, 10 Jul 2008 00:57:57 +0200 | From | "Hans J. Koch" <> | Subject | Re: [PATCH] uio_pdrv: fix memory leak and license specification. |
| |
On Wed, Jul 09, 2008 at 08:13:23AM +0200, Uwe Kleine-König wrote: > Thanks to Magnus Damm for pointing that out.
Yep, good catch.
Thanks, Hans
> > Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>
Acked-by: Hans J. Koch <hjk@linutronix.de>
> --- > Hi, > > Greg, this bases on uio-add-generic-uio-platform-driver.patch that is > already in your queue. > > IMHO the best is to squash these two patches together. Can you do that? > > Best regards > Uwe > > drivers/uio/uio_pdrv.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/uio/uio_pdrv.c b/drivers/uio/uio_pdrv.c > index 5d0d2e8..0b4ef39 100644 > --- a/drivers/uio/uio_pdrv.c > +++ b/drivers/uio/uio_pdrv.c > @@ -88,6 +88,8 @@ static int uio_pdrv_remove(struct platform_device *pdev) > > uio_unregister_device(pdata->uioinfo); > > + kfree(pdata); > + > return 0; > } > > @@ -114,5 +116,5 @@ module_exit(uio_pdrv_exit); > > MODULE_AUTHOR("Uwe Kleine-Koenig"); > MODULE_DESCRIPTION("Userspace I/O platform driver"); > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("platform:" DRIVER_NAME); > -- > 1.5.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |