Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: request_firmware vs. resume (was Re: [PATCH] bnx2 - use request_firmware()) | Date | Wed, 9 Jul 2008 23:58:31 +0200 |
| |
On Wednesday, 9 of July 2008, Theodore Tso wrote: > On Wed, Jul 09, 2008 at 11:13:54PM +0200, Rafael J. Wysocki wrote: > > > Be careful about request_firmware. Doing it right w.r.t. > > > suspend/resume is quite tricky: you have to load it from userspace > > > before kernel starts, so that you can use it during resume... > > > > Rather, you have to cache it in memory before your ->suspend() is invoked. > > Translation: so much for saving "non-swappable kernel memory". > Unless, of course we add a pre-suspend hook. (Which doesn't exist > yet, AFAICT from a quick perusal of Documentation/power/devices.txt.)
No, it doesn't.
You will be able to register a suspend notifier instead, but this requires one fix which is in the works.
Thanks, Rafael
| |