Messages in this thread | | | Date | Wed, 9 Jul 2008 23:44:19 +0200 | From | Cezary Jackiewicz <> | Subject | Re: [RESEND] [PATCH -next 2/2] acpi,rfkill,backlight: comapl-laptop update - use rfkill switch subsystem |
| |
Dnia 2008-07-09, o godz. 23:33:01 Ivo van Doorn <ivdoorn@gmail.com> napisał(a):
> On Wednesday 09 July 2008, Cezary Jackiewicz wrote: > > From: Cezary Jackiewicz <cezary.jackiewicz@gmail.com> > > > > Remove unnecessary attributes, use rfkill switch subsystem. > > I'm missing a call to rfkill_force_state() to inform the rfkill subsystem that > the key has been toggled. This function should be called when the hardware > has raised the interrupt about the pressed event, or when the function > which polls the register notices the state change. > > As the patch works now, it means that the driver will only listen to > events coming from rfkill and it doen't provide any updates itself. > > Ivo
Does calling rfkill_force_state () is mandatory? This driver implement get_state() hook, @state is always up-to-date.
-- Cezary
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |