lkml.org 
[lkml]   [2008]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Mark i2o config broken on 64-bit platforms.
    From
    Date
    On Wed, 2008-07-09 at 21:06 +0200, Miquel van Smoorenburg wrote:
    > On Wed, 2008-07-09 at 16:49 +0100, Alan Cox wrote:
    > > On Wed, 09 Jul 2008 15:15:14 +0100
    > > David Howells <dhowells@redhat.com> wrote:
    > >
    > > > Miquel van Smoorenburg <miquels@cistron.nl> wrote:
    > > > Maybe, but have you looked at i2o_cfg_passthru()? Take this, for example:
    > > >
    > > > /* Allocate memory for the transfer */
    > > > p = kmalloc(sg_size, GFP_KERNEL);
    > > > ...
    > > > //TODO 64bit fix
    > > > sg[i].addr_bus = virt_to_bus(p);
    > > >
    > > > That looks distinctly dodgy. virt_to_bus() returns a 64-bit address, and as
    > >
    > > Agreed - stick | GFP_DMA32 on the end then ;)
    >
    > GFP_DMA32 doesn't work with kmalloc(), you need dma_alloc_coherent() or
    > pci_alloc_consistent() [here, i2o_dma_alloc() ]

    Yes it does ... it was specifically designed for it. GFP_DMA32 was
    introduced to allow this type of thing to happen (in the old days most
    drivers were allowed to assume kmalloc would return memory whose
    physical address was < 4GB; GFP_DMA32 allows that to continue while
    allowing kmalloc to stray beyond 4GB physical).

    > GFP_DMA would work though, as a quick bandaid.

    James




    \
     
     \ /
      Last update: 2008-07-09 21:17    [W:4.098 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site