lkml.org 
[lkml]   [2008]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Mark i2o config broken on 64-bit platforms.
    On Wed, 09 Jul 2008 15:15:14 +0100
    David Howells <dhowells@redhat.com> wrote:

    > Miquel van Smoorenburg <miquels@cistron.nl> wrote:
    > Maybe, but have you looked at i2o_cfg_passthru()? Take this, for example:
    >
    > /* Allocate memory for the transfer */
    > p = kmalloc(sg_size, GFP_KERNEL);
    > ...
    > //TODO 64bit fix
    > sg[i].addr_bus = virt_to_bus(p);
    >
    > That looks distinctly dodgy. virt_to_bus() returns a 64-bit address, and as

    Agreed - stick | GFP_DMA32 on the end then ;)


    Alan


    \
     
     \ /
      Last update: 2008-07-09 18:25    [W:0.026 / U:93.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site