Messages in this thread | | | Date | Wed, 9 Jul 2008 14:29:32 +0200 | From | "pHilipp Zabel" <> | Subject | Re: [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device |
| |
On Wed, Jul 9, 2008 at 2:13 PM, ian <spyro@f2s.com> wrote: > On Wed, 2008-07-09 at 12:50 +0100, Ben Dooks wrote: >> >> So, the enable/disable calls might be useful, however is there any >> reason this could not be handled by the clock framework? The >> suspend/resume entries where not used, and I belive should not be in >> here. > > Hi Ben, > > I agree with you on wrapping the platform device, however the enable / > disable methods must stay.
Ack on that. Also look also at the ds1wm driver. Right now it provides its own enable/disable methods in platform data because it predates the MFD core. It should be changed into an MFD cell driver, so enable/disable methods in mfd_cell would be most useful for it.
> Other cores need them, and they arent only there for clock support. > > I've just looked at the TMIO MMC driver to refersh my memory and the > suspend / resume hooks must stay also. TMIO MMC needs to be handled > differently when suspending and when being disabled (loss of state when > disabled). > > As yet, only tc6393 is 'in tree' but Im waiting for the core to settle > down before I convert my other TMIO based code (again again) to the new > core. > > So, in summary - > > ACK to your changes to wrap the device as an 'mfd_device' > NAK to deleting the mfd_cell power management. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
regards Philipp
| |