lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 19/58] microblaze_v5: early_printk support
> +++ b/arch/microblaze/kernel/early_printk.c
> @@ -0,0 +1,130 @@

> +#ifdef CONFIG_EARLY_PRINTK
> +#define BASE_ADDR ((unsigned char *)CONFIG_EARLY_PRINTK_UARTLITE_ADDRESS)

This is a problem - default value of EARLY_PRINTK_UARTLITE_ADDRESS is
0x0, so by default the kernel will try to access a uartlite at 0x0
which is the reset vector! I know there is the test in the actual
output routine but it's not good to rely on that in the default case.

Can we either

#if CONFIG_EARLY_PRINTK_UARTLITE_ADDRESS==0
#warning EARLY_PRINTK address not set, disabling
...
#else
..
#endif

or query the OF subsystem (is it up yet?), and default to using the
first uartlite in the system for early printk?

John


\
 
 \ /
  Last update: 2008-07-09 01:49    [W:0.248 / U:42.312 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site